-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated develop-4.0 with changes from develop #842
Merged
yaroslavyaroslav
merged 35 commits into
web3swift-team:develop-4.0
from
JeneaVranceanu:develop-4.0
Jan 16, 2024
Merged
chore: updated develop-4.0 with changes from develop #842
yaroslavyaroslav
merged 35 commits into
web3swift-team:develop-4.0
from
JeneaVranceanu:develop-4.0
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generation amount of addresses added - Generation wallet with index > 9 fixed - Test generation addresses added
- Removed prefix path from address generation
- pathAppendix declaration place changed
- small refactoring
fix: createNewAccount always non-hardened derivation
chore: refactoring
feat: sign without hash
feat: implement eth_getLogs
…eb3swift-team#791) * Update HexDecodable+Extensions.swift * Update Data+Extension.swift * Update String+Extension.swift * chore: refactoring + documentation for Data.fromHex function * updates as per conversations * chore: updated docs for randomBytes + minor refactoring * chore: fixed typo in Data+Extension.swift * chore: lint issue fixed * add string spit test * Revert "add string spit test" github issue This reverts commit e8a5e2b. --------- Co-authored-by: Jenea Vranceanu <[email protected]> Co-authored-by: Jenea Vranceanu <[email protected]>
* develop: (24 commits) refactor: random bytes generation; data and string extensions update (web3swift-team#791) encodeTopic bytes should accept hex string add more test for encodeTopic Trim Trailing Whitespace remove a force unwrap feat: enable encode Event and IETH.getLogs - isHardened check removed from createNewCustomChildAccount - linter warning fixed chore: trailing closure style for compactMap fix: used short notation for null checking fix: trimming / only if it's present as a prefix; using let for 'newPath'; - Test testAddressGeneration modified with hardcoded addresses chore: refactoring of createNewCustomChildAccount - bug with original pathAppendix fixed fix: createNewAccount always non-hardened derivation - Trailing Whitespace fixed in tests - not used code removed - small refactoring - closure style updated - pathAppendix declaration place changed - linter Trailing Whitespace Violation fixed - Grammar fixed - Removed prefix path from address generation ...
JeneaVranceanu
changed the title
chore: merging develop into develop-4.0
chore: updated develop-4.0 with changes from develop
Jan 16, 2024
* develop: (24 commits) chore: added docs; new test for ABI.Element.Function; chore: Update Sources/Web3Core/EthereumNetwork/Request/APIRequest+Methods.swift chore: Update Sources/Web3Core/EthereumNetwork/Request/APIRequest+Methods.swift fix: testDecodeMulticallCopy fix: code spell chore: error messages updated chore: isHex string extension tests fix: isHex string extension function refactoring chore: avoiding try? in tests (try is more preffered) chore: missing space added chore: comment refactoring chore: docs refactoring chore: docs refactoring chore: code reordering chore: error message update update function documentation fix codespell resolve reviews suggestions add missing test contract bytecode fix eth method ... # Conflicts: # Tests/web3swiftTests/localTests/AdvancedABIv2Tests.swift # Tests/web3swiftTests/localTests/UncategorizedTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updating develop 4.0
By submitting this pull request, you are confirming the following:
develop
branch.